Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove google-private #2513

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove google-private #2513

merged 1 commit into from
Mar 15, 2022

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Mar 15, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / Why we need it:
removes google-private provider from allocation-endpoint terraform and use google provider.

Which issue(s) this PR fixes:
Closes #2512

@google-oss-prow google-oss-prow bot added the lgtm label Mar 15, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 23894dc3-40a3-48ff-be39-b0da0a943cf1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2513/head:pr_2513 && git checkout pr_2513
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-144f282

@pooneh-m pooneh-m merged commit 30acf34 into googleforgames:main Mar 15, 2022
@SaitejaTamma SaitejaTamma added this to the 1.22.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@roberthbailey roberthbailey

Labels
approved lgtm size/XS
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

The allocation-endpoint sample terraform is using goolge-private provider
4 participants
@pooneh-m @agones-bot @roberthbailey @SaitejaTamma